Opened 11 years ago

Closed 11 years ago

#85 closed defect (wontfix)

session destruction not complete if session dirs contain symlinks (for eg. supervise)

Reported by: jrollins Owned by: jrollins
Priority: major Component: cereal
Keywords: Cc:
Sensitive: no


The new update-service script requires symlinks for the supervise directories. While there are some other unresolved issues with this (see DebianBug:466885), one upshot is that the directories that these symlinks point to, if outside the sessiondir, are not destroyed with the current "cereal-admin destroy SESSION" command.

I'm not sure how to handle this. We can't destroy all referent things, since run and log/run are both links to the mainrun and logrun scripts in /usr/share/cereal.

Change History (2)

comment:1 Changed 11 years ago by Daniel Kahn Gillmor

run and log/run don't point to directories; they point to files. is that a different case?

As far as the logs go: do we want to destroy the logs on destroy? I wouldn't think it was the end of the world if the logs stuck around. In fact, it might be a nice feature, as long as it's documented. Alternately, we could add a --rm-logs flag to destroy so that the user can make a convenient and explicit choice to do so.

If we create the supervise directories ourselves during create (and link to them), then we could get rid of them ourselves during destroy, right?

comment:2 Changed 11 years ago by jrollins

Resolution: wontfix
Status: newclosed

As of runit 1.8.0-3, update-service will not move supervise directories if they reside outside of /etc. Since our service directories are in /var/lib/cereal/sesssions, nothing will be moved, and therefore cereal-admin destroy will properly destroy all of the session directories.

Note: See TracTickets for help on using tickets.