Opened 5 years ago

Closed 5 years ago

#47 closed defect (fixed)

create better error handling infrastructure for make-debirf

Reported by: jrollins Owned by: dkg
Priority: major Component: debirf
Keywords: Cc:
Sensitive:

Description

make-debirf needs some sort of error handling infrastructure to properly halt to build process on fatal errors. currently just adding '-e' to the shbang line for make-debirf doesn't do it, since some plugins (install-kernel for instance) return with non-zero exit codes even though they are apparently working ok, therefore causing run-parts to exit non-zero and kill the script. Maybe the right thing to do is to audit the plugins and make sure they all exit with 0 when they are doing the right thing.

Change History (2)

comment:1 in reply to: ↑ description Changed 5 years ago by dkg

Replying to jrollins:

Maybe the right thing to do is to audit the plugins and make sure they all exit with 0 when they are doing the right thing.

i think this is the correct thing to do, definitely. plugins should return 0 on success, non-zero on failure.

Whether setting -e in make-debirf is the right way to handle those errors themselves is another issue -- we might want to do more sophisticated reporting/error handling too. but set -e and proper plugin return values would be a good start.

comment:2 Changed 5 years ago by jrollins

  • Resolution set to fixed
  • Status changed from new to closed

make-debirf now runs with the '-e' option to bash. So far it looks like it was just the install-kernel plugin that needed to be properly setup, which it is now.

Note: See TracTickets for help on using tickets.